wp-downloadmanager bug fix 1.68.1

11/14/2016 How I solved it

So if you want a WordPress plugin for managing downloads and to be capable of working with external URLs you can choose this plugin(wp-downloadmanager). Unfortunately on the WordPress plugin directory, there aren't so many plugins that have in their design external URLs, of course, external URLs aren't what you would want most of the time but there are some cases where such URLs are preferred and this was my case too. After installing this plugin I detected that it had a bug exactly when working with external URLs. I had notified the author and he said that he might fix this bug. The bug consists of unusable external download links saved in the database, this happens when the remote download URL is a bit ugly, and it contains characters like &,? and others instead of just slashes and maybe a dot. The reason for this bug is the usage of WordPress function wp_kses_post(), which will encode & in & and thus breaking the URL. I really see no reason of using wp_kses_post() as that function is not for Sanitization of URLs if we look in the WordPress documentation we will see that the function for URL Sanitization should be esc_url_raw( $url, (array) $protocols = null ) (since 2.8). Update: I deleted my fix from here as the author of the plugin has fixed the issue. ( https://github.com/lesterchan/wp-downloadmanager/commit/ddba63d0680b6399f9caeed9e866282a3f1c9a8b ) That is very nice of him.

Andrei's bookshelf: read

Before Us

by Nathan Hystad

In this second book, the three robots become much more than just sidekicks. They play a crucial role in the story, providing humor, emotional support, and even some unexpected twists. Their interactions with each other and the human char...

Below Us

by Nathan Hystad

I finished the book two recently. I am eager for the third in this series. The popularity of the book is warranted. The story is a bit more in the fantasy direction. That being said, the author seems to have fantastic character-building ...

Ogres

by Adrian Tchaikovsky

For me, it explores two engaging ideas. Firstly, that exploitation and oppression should and may lead to justifiable more outstanding forms of violence. And that personal goals can rarely trump class interests which may be a bit fantasy,...

Insurgency Harmony

by T.M. Clayton

Insurgency Harmony delves into one vision of how the long-term dynamics of insurgency can play on a future timeline. It might be further from plausibility and may hit close to contemporary politics, but it seems to encapsulate that many ...

Tags